Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for windows builds #831

Merged
merged 2 commits into from
Mar 4, 2016
Merged

Better support for windows builds #831

merged 2 commits into from
Mar 4, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #323

@flovilmart flovilmart mentioned this pull request Mar 4, 2016
Closed
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@drew-gross drew-gross closed this Mar 4, 2016
@drew-gross drew-gross reopened this Mar 4, 2016
@codecov-io
Copy link

Current coverage is 91.68%

Merging #831 into master will decrease coverage by -0.02% as of 0788914

@@            master    #831   diff @@
======================================
  Files           71      71       
  Stmts         4100    4100       
  Branches       843     843       
  Methods          0       0       
======================================
- Hit           3760    3759     -1
  Partial         10      10       
- Missed         330     331     +1

Review entire Coverage Diff as of 0788914

Uncovered Suggestions

  1. +0.19% via ...outers/LogsRouter.js#29...36
  2. +0.19% via src/PromiseRouter.js#105...112
  3. +0.14% via src/transform.js#471...476
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

drew-gross added a commit that referenced this pull request Mar 4, 2016
@drew-gross
Merge pull request #831 from ParsePlatform/flovilmart.fixWindowsTests
3e6c53c 
Better support for windows builds
@drew-gross drew-gross merged commit 3e6c53c into master Mar 4, 2016
@flovilmart flovilmart deleted the flovilmart.fixWindowsTests branch March 4, 2016 23:07
aneeshd16 added a commit to aneeshd16/parse-server that referenced this pull request Mar 5, 2016
@aneeshd16
Modified the npm dev script to support Windows
7cc0599 
Windows does not support shebangs/hashbangs. Added the node command to run the bin/dev script. Extension of parse-community#831
@aneeshd16 aneeshd16 mentioned this pull request Mar 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running tests on Windows
4 participants
@flovilmart @facebook-github-bot @codecov-io @drew-gross