Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix includeAll for querying a Pointer and Pointer array #7002

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Fix includeAll for querying a Pointer and Pointer array #7002

merged 3 commits into from
Nov 11, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 11, 2020 •
edited
Loading

Fix #5521

@cbaker6 cbaker6 marked this pull request as draft November 11, 2020 14:35
@codecov
Copy link

codecov bot commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #7002 (c3b1ad0) into master (b4ec63e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7002      +/-   ##
==========================================
- Coverage   93.86%   93.85%   -0.01%     
==========================================
  Files         169      169              
  Lines       12405    12405              
==========================================
- Hits        11644    11643       -1     
- Misses        761      762       +1
Impacted Files Coverage Δ
src/RestQuery.js 95.51% <100.00%> (ø)
src/RestWrite.js 93.82% <0.00%> (-0.33%) ⬇️
src/Adapters/Auth/httpsRequest.js 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ec63e...c3b1ad0. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Nov 11, 2020

@dplewis @mtrezza @davimacedo I have added a fix, but not sure if it's the best way to do it. Basically, includeAll was only checking the schema for Pointer types which caused it to miss an array of pointers. I don't know of another way to get more info about the schema, so I automatically include the field if it's Array type since it doesn't seem like it would hurt anything.

Thoughts, improvements?

@cbaker6 cbaker6 closed this Nov 11, 2020
@cbaker6 cbaker6 reopened this Nov 11, 2020
@cbaker6 cbaker6 marked this pull request as ready for review November 11, 2020 16:01
@dplewis
Copy link
Member

dplewis commented Nov 11, 2020

@cbaker6 Thats how I would do it (see #6926 (comment)). If it doesn't hurt.

@dplewis dplewis linked an issue Nov 11, 2020 that may be closed by this pull request
query.includeAll() does not include array of Pointers #6926
Closed
@dplewis dplewis merged commit 568c285 into parse-community:master Nov 11, 2020
@cbaker6 cbaker6 deleted the fixInclude branch November 11, 2020 17:02
mtrezza added a commit to mtrezza/parse-server that referenced this pull request Dec 4, 2020
@mtrezza
Merge commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387'
dc9f90d 
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387':
  fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007)
  fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009)
  fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008)
  fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011)
  update stale bot (parse-community#6998)
  fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005)
  fix(beforeSave): Skip Sanitizing Database results (parse-community#7003)
  Fix includeAll for querying a Pointer and Pointer array (parse-community#7002)
  Init (parse-community#6999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplewis dplewis dplewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cbaker6 @dplewis