Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set objectId into query for Email Validation #6930

Merged
merged 5 commits into from
Oct 9, 2020

Conversation

Danaru87
Copy link
Contributor

@Danaru87 Danaru87 commented Oct 6, 2020

Fixes #6921

It seems that LiveQueryController need original object id to send event.
But, email validation was not retrieving the user validating email address.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #6930 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6930      +/-   ##
==========================================
- Coverage   93.81%   93.77%   -0.04%     
==========================================
  Files         169      169              
  Lines       12216    12218       +2     
==========================================
- Hits        11460    11458       -2     
- Misses        756      760       +4     
Impacted Files Coverage Δ
src/Controllers/UserController.js 94.49% <100.00%> (+0.10%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.92% <0.00%> (-0.67%) ⬇️
src/RestWrite.js 93.82% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b26cc0...d1038b0. Read the comment docs.

@davimacedo
Copy link
Member

Thanks for the PR. Could you please run npm run lint and fix the lint issue? It would be also good to add a regression test.

@Danaru87
Copy link
Contributor Author

Danaru87 commented Oct 7, 2020

Lint ok !

For regression test, i have no idea how to do that, can you give me some help ?

@davimacedo
Copy link
Member

Take a look at this file: https://github.com/parse-community/parse-server/blob/master/spec/ParseLiveQuery.spec.js

You need to create a new test case similar to these ones that reproduces the problem that you are trying to solve. This test case should not pass before your change and pass after your change.

@Danaru87
Copy link
Contributor Author

Danaru87 commented Oct 8, 2020

Take a look at this file: https://github.com/parse-community/parse-server/blob/master/spec/ParseLiveQuery.spec.js

You need to create a new test case similar to these ones that reproduces the problem that you are trying to solve. This test case should not pass before your change and pass after your change.

Working on it ;)

@Danaru87
Copy link
Contributor Author

Danaru87 commented Oct 8, 2020

Test done !

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Only a small suggestion.

src/Controllers/UserController.js Outdated Show resolved Hide resolved
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 84896db into parse-community:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveQuery _User and Email Verification
2 participants