Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Handle properly keys for pointer fields #6499

Merged

Conversation

Moumouls
Copy link
Member

Detect custom key on the child object

@Moumouls Moumouls added type:bug Impaired feature or lacking behavior that is likely assumed enhancement labels Mar 11, 2020
@Moumouls Moumouls self-assigned this Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #6499 into master will increase coverage by 0.06%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6499      +/-   ##
==========================================
+ Coverage   93.92%   93.99%   +0.06%     
==========================================
  Files         169      169              
  Lines       11808    11836      +28     
==========================================
+ Hits        11091    11125      +34     
+ Misses        717      711       -6     
Impacted Files Coverage Δ
src/GraphQL/loaders/defaultRelaySchema.js 94.73% <ø> (-0.27%) ⬇️
src/GraphQL/loaders/parseClassMutations.js 100.00% <ø> (+1.03%) ⬆️
src/GraphQL/helpers/objectsQueries.js 90.83% <93.75%> (+0.08%) ⬆️
src/GraphQL/ParseGraphQLSchema.js 97.40% <100.00%> (+0.15%) ⬆️
src/GraphQL/loaders/parseClassQueries.js 97.95% <100.00%> (ø)
src/RestWrite.js 93.81% <0.00%> (+0.32%) ⬆️
src/Adapters/Auth/apple.js 100.00% <0.00%> (+12.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d76b8...acda91b. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 255cb15 into parse-community:master Mar 23, 2020
@mtrezza mtrezza removed type:bug Impaired feature or lacking behavior that is likely assumed 🧬 enhancement labels Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants