Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group aggregation supports multiple columns for postgres #6483

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Group aggregation supports multiple columns for postgres #6483

merged 4 commits into from
Mar 9, 2020

Conversation

srameshr
Copy link
Contributor

@srameshr srameshr commented Mar 9, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #6483 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6483      +/-   ##
==========================================
- Coverage   93.96%   93.96%   -0.01%     
==========================================
  Files         169      169              
  Lines       11801    11808       +7     
==========================================
+ Hits        11089    11095       +6     
- Misses        712      713       +1     
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.74% <100.00%> (+0.01%) ⬆️
src/RestWrite.js 93.64% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f695459...ce5a031. Read the comment docs.

@srameshr
Copy link
Contributor Author

srameshr commented Mar 9, 2020

@davimacedo @dplewis
Could you guys review this PR?

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. LGTM!

@davimacedo davimacedo merged commit ef17dc4 into parse-community:master Mar 9, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…nity#6483)

* Group aggregation supports multiple columns for postgres

* Group aggregation supports multiple columns for postgres

* Group aggregation supports multiple columns for postgres

* Group aggregation supports multiple columns for postgres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants