Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws to the latest version 🚀 #6478

Merged
2 commits merged into from
Mar 9, 2020
Merged

Update ws to the latest version 🚀 #6478

2 commits merged into from
Mar 9, 2020

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 8, 2020


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency ws was updated from 7.2.1 to 7.2.2.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: lpinca
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@ghost ghost added the Merge On Green label Mar 8, 2020
@ghost ghost merged commit f695459 into master Mar 9, 2020
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #6478 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6478      +/-   ##
==========================================
- Coverage   93.96%   93.94%   -0.03%     
==========================================
  Files         169      169              
  Lines       11801    11801              
==========================================
- Hits        11089    11086       -3     
- Misses        712      715       +3
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.79% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f1454...9ca8c3a. Read the comment docs.

@greenkeeper greenkeeper bot deleted the greenkeeper/ws-7.2.2 branch March 9, 2020 04:22
noahsilas added a commit to noahsilas/parse-server that referenced this pull request Mar 18, 2020
It's not clear what happened in parse-community#6478, but it appears that it dropped
the `ws` dependency of the `parse` package when it was updating the
local version of the dependency. This means that running `npm install`
dirties the working tree, which is surprising!

I've filed an issue for the surprising behavior from greenkeeper:
greenkeeperio/greenkeeper-lockfile#250
noahsilas added a commit to noahsilas/parse-server that referenced this pull request Mar 18, 2020
It's not clear what happened in parse-community#6478, but it appears that it dropped
the `ws` dependency of the `parse` package when it was updating the
local version of the dependency. This means that running `npm install`
dirties the working tree, which is surprising!

A similar problem seems to have occurred in parse-community#6504, that time related to
the `commander` package.

I've filed an issue for the surprising behavior from greenkeeper:
greenkeeperio/greenkeeper-lockfile#250
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* fix(package): update ws to version 7.2.2

* chore(package): update lockfile package-lock.json

Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants