skip cleanup so we don't erase babel and stuff #6452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplewis
reviewed
Feb 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #6452 +/- ##
===========================================
+ Coverage 83.56% 93.93% +10.36%
===========================================
Files 169 169
Lines 11796 11796
===========================================
+ Hits 9857 11080 +1223
+ Misses 1939 716 -1223
Continue to review full report at Codecov.
|
|
I don't think it is since no tests were changed. I understand that the error already existed. We are only improving the feedback. |
|
got it. changing. |
davimacedo
approved these changes
Feb 29, 2020
|
@dplewis @davimacedo boo. Travis still not happy. I won't be able to look at this weekend, but I can definitely get on it on Monday. |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* skip cleanup so we don't erase babel and stuff * skip cleanup the right way! * Add change log and bump version * include one more commit * remove breaking change from non breaking change. Co-authored-by: Diamond Lewis <findlewis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.