Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min mongodb to 3.6 in prep for parse-server 4.0 #6445

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Feb 26, 2020

fixes: #6444

@TomWFox there may be places in docs where we need to change this too??

pass the function.

Also remove the boolean argument in tests that no longer exists.
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #6445 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6445      +/-   ##
==========================================
- Coverage   93.97%   93.94%   -0.03%     
==========================================
  Files         169      169              
  Lines       11811    11794      -17     
==========================================
- Hits        11099    11080      -19     
- Misses        712      714       +2     
Impacted Files Coverage Δ
src/RestWrite.js 93.64% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d7da58...8321994. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce!

Copy link
Contributor

@NotBobTheBuilder NotBobTheBuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thunder firmly stolen! Thank you for doing this!

@acinader acinader merged commit 5c79189 into master Feb 27, 2020
@dplewis dplewis deleted the set-min-mongo-to-3.6 branch February 27, 2020 23:38
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…6445)

* Set min mongodb to 3.6 in prep for parse-server 4.0

fixes: 6444

* don't use anonymous functions when we can just
pass the function.

Also remove the boolean argument in tests that no longer exists.

* generate the correct lock file.  ooops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove: skipMongoDBServer13732Workaround
3 participants