Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Fix Geo Queries #6363

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

Moumouls
Copy link
Member

Due to a lack of tests on geo queries, when we removed the $ from constraints we broke some of geo queries.

@Moumouls Moumouls added the type:bug Impaired feature or lacking behavior that is likely assumed label Jan 25, 2020
@Moumouls Moumouls self-assigned this Jan 25, 2020
@Moumouls
Copy link
Member Author

Ci seems to be okay, we got an issue on push controller

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #6363 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6363      +/-   ##
==========================================
+ Coverage   93.84%   93.92%   +0.07%     
==========================================
  Files         169      169              
  Lines       11626    11629       +3     
==========================================
+ Hits        10911    10922      +11     
+ Misses        715      707       -8
Impacted Files Coverage Δ
src/GraphQL/transformers/query.js 89.88% <100%> (+13.14%) ⬆️
src/Routers/PushRouter.js 93.1% <0%> (-3.45%) ⬇️
src/RestWrite.js 93.62% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab3665...8e9171e. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@davimacedo davimacedo merged commit df3fa02 into parse-community:master Jan 28, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@mtrezza mtrezza removed the type:bug Impaired feature or lacking behavior that is likely assumed label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants