Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeFind: Improve request.query object #6237

Merged
merged 2 commits into from
Nov 23, 2019
Merged

beforeFind: Improve request.query object #6237

merged 2 commits into from
Nov 23, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Nov 23, 2019

Closes: #6164

Adds ascending, select, exclude, readPreference.

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #6237 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6237      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +0.01%     
==========================================
  Files         167      167              
  Lines       11306    11304       -2     
==========================================
  Hits        10620    10620              
+ Misses        686      684       -2
Impacted Files Coverage Δ
src/triggers.js 94.46% <100%> (+0.37%) ⬆️
src/RestWrite.js 93.75% <0%> (-0.17%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.09%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.74% <0%> (+0.46%) ⬆️
src/Routers/PushRouter.js 96.55% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf87d8...e7a30a2. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Nov 23, 2019

@acinader How does this look?

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement

@dplewis dplewis merged commit 2f05d81 into master Nov 23, 2019
@dplewis dplewis deleted the beforeFind-query branch November 23, 2019 17:38
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* beforeFind: Improve request.query object

Closes: parse-community#6164

* can modify exclude query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseQuery.order is missing in beforeFind hook
2 participants