Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Google Play Games Service #6147

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Support Google Play Games Service #6147

merged 4 commits into from
Oct 28, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 19, 2019 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 19, 2019 •
edited
Loading

Codecov Report

Merging #6147 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6147      +/-   ##
==========================================
- Coverage   93.79%   93.76%   -0.03%     
==========================================
  Files         166      167       +1     
  Lines       11271    11299      +28     
==========================================
+ Hits        10572    10595      +23     
- Misses        699      704       +5
Impacted Files Coverage Δ
src/Adapters/Auth/gpgames.js 100% <100%> (ø)
src/Adapters/Auth/index.js 93.44% <100%> (+0.1%) ⬆️
src/Adapters/Auth/gcenter.js 98.24% <100%> (ø) ⬆️
src/Routers/PushRouter.js 93.1% <0%> (-3.45%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.27% <0%> (-0.71%) ⬇️
src/RestWrite.js 93.58% <0%> (-0.31%) ⬇️
src/Routers/FilesRouter.js 92.72% <0%> (-0.26%) ⬇️
src/Adapters/Files/FilesAdapter.js 100% <0%> (ø) ⬆️
src/ParseServer.js 97.59% <0%> (+0.05%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d2aa3...5ec3514. Read the comment docs.

davimacedo
davimacedo approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@acinader
Copy link
Contributor

a test?

@dplewis dplewis merged commit b447269 into master Oct 28, 2019
@dplewis dplewis deleted the gpgames branch October 28, 2019 18:17
@TomWFox TomWFox mentioned this pull request Dec 6, 2019
Open
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis
Support Google Play Games Service (parse-community#6147)
aff2c57 
* Support Google Play Games Service

* clean up

* improve coverage

* more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@acinader acinader Awaiting requested review from acinader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need of additional authentication method on Google Play, Game Center
3 participants
@dplewis @acinader @davimacedo