Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for protectedFields when using Find without constraints. #5967

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Add test cases for protectedFields when using Find without constraints. #5967

merged 1 commit into from
Aug 25, 2019

Conversation

yomybaby
Copy link
Contributor

This PR has two test cases.

I found a bug last week. I talked about this with @davimacedo .
https://community.parseplatform.org/t/protectedfields-vs-usersensitivefields/616/6

Now, this bug already fixed by #5951
But It needs to add some cases for finding users without constraints.

@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

17 similar comments
@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #5967 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
- Coverage   93.71%   83.01%   -10.7%     
==========================================
  Files         156      156              
  Lines       10926    10926              
==========================================
- Hits        10239     9070    -1169     
- Misses        687     1856    +1169
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.98% <0%> (-93.7%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.23% <0%> (-0.71%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.39% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5838efc...b10bfb7. Read the comment docs.

davimacedo
davimacedo approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

@davimacedo davimacedo merged commit d0dc511 into parse-community:master Aug 25, 2019
@yomybaby
Copy link
Contributor Author

Thanks :)

@yomybaby yomybaby deleted the add-user-pii-spec branch August 25, 2019 10:44
@yomybaby yomybaby mentioned this pull request Aug 27, 2019
Merged
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@yomybaby @davimacedo
Add test cases for protectedFields when using Find without constraint…
b57ffe0 
…s. (parse-community#5967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yomybaby @davimacedo