Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix month in aggregate tests #5879

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

davimacedo
Copy link
Member

These two tests only break in the last day of the month, depending on your timezone and the time of day you are running the tests. They just failed for me and I noticed.

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #5879 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5879      +/-   ##
==========================================
- Coverage   93.73%   93.69%   -0.04%     
==========================================
  Files         153      153              
  Lines       10703    10703              
==========================================
- Hits        10032    10028       -4     
- Misses        671      675       +4
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.21% <0%> (-0.71%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.79% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a8d33...ea5612d. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing. time is hard.

@davimacedo davimacedo merged commit f3b8424 into parse-community:master Aug 1, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants