Fix Bug in GraphQL _or Operator #5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I remember correctly, that is used in a lot of places. Addressing it now would be a good idea. |
Codecov Report
@@ Coverage Diff @@
## master #5840 +/- ##
==========================================
- Coverage 93.72% 93.68% -0.04%
==========================================
Files 148 148
Lines 10304 10304
==========================================
- Hits 9657 9653 -4
- Misses 647 651 +4
Continue to review full report at Codecov.
|
|
I'll merge this PR for now, since addressing the other occurrences might take some time. |
|
I open an issue to address it later: #5842 |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was caused by legacy code
subq.hasOwnProperty(key). I changed toObject.hasOwnProperty.call(subq, key)and fixed the problem. I see there are other codes that do the same. It would be probably good to add the prototype format in our lint and fix in all places (ref: https://eslint.org/docs/rules/no-prototype-builtins). @acinader @dplewis any thoughts?