Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Linking with Apple Auth #5755

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Fix: Linking with Apple Auth #5755

merged 1 commit into from
Jul 3, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 3, 2019

Fixing #5694

*Properly loads the provider
*Rename from apple-signin to apple (key names can't have hyphens)
*Rename id_token to id (auth adapters require id)

{
  "apple": {
    "id": "jwt token for user", // required, used for validation
    "access_token": "an authorized access token for the user", // optional, currently does nothing but maybe in the future
  }
}

There is an optional client_id that you can pass in to Server Auth Configuration for extra validation.

{
  auth: {
   apple: {
     client_id: "", // optional, use the Service ID from apple.
  }
}

Rename from apple-signin to apple (key names can't have hyphens
Rename id_token to id (auth adapters require id)
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #5755 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5755      +/-   ##
==========================================
+ Coverage   93.62%   93.63%   +0.01%     
==========================================
  Files         145      145              
  Lines       10211    10212       +1     
==========================================
+ Hits         9560     9562       +2     
+ Misses        651      650       -1
Impacted Files Coverage Δ
src/Adapters/Auth/apple.js 100% <100%> (ø)
src/Adapters/Auth/index.js 92.85% <100%> (+0.12%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.82% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.49% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c40310...cc84beb. Read the comment docs.

@dplewis dplewis requested review from acinader and davimacedo July 3, 2019 03:48
@dplewis dplewis merged commit 3a7b0c4 into master Jul 3, 2019
@dplewis dplewis deleted the apple-signin-fix branch July 3, 2019 21:28
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Rename from apple-signin to apple (key names can't have hyphens
Rename id_token to id (auth adapters require id)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants