Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppSecret to Facebook Auth #5695

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Add AppSecret to Facebook Auth #5695

merged 1 commit into from
Jun 20, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 19, 2019

Closes: #5448

Copied existing code from FacebookAcountKit

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #5695 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5695      +/-   ##
==========================================
+ Coverage   94.16%   94.21%   +0.05%     
==========================================
  Files         130      130              
  Lines        9264     9270       +6     
==========================================
+ Hits         8723     8734      +11     
+ Misses        541      536       -5
Impacted Files Coverage Δ
src/Adapters/Auth/facebook.js 86.95% <100%> (+10.48%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.9% <0%> (+0.08%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.45% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcdf2d7...ecebb7a. Read the comment docs.

@dplewis dplewis requested a review from acinader June 19, 2019 22:35
@dplewis dplewis merged commit 6385dee into master Jun 20, 2019
@dplewis dplewis deleted the facebook-secret branch June 20, 2019 19:16
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting up appsecret_proof for Facebook calls
2 participants