Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add page size and current page index to data browser #2591

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

NicolasSuzuki
Copy link

@NicolasSuzuki NicolasSuzuki commented Sep 7, 2024

New Pull Request Checklist

[ ] I am not disclosing a vulnerability.
[ X ] I am creating this PR in reference to an issue.

Issue Description

Closes: #2571

Approach

Remove the field recommendation for the filter, introduce a list of draft filters that replaces the recommendation, and the new lines are automatically focused.

image

TODOs before merging

[ ] Add tests
[ ] Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Sep 7, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Copy link

uffizzi-cloud bot commented Sep 7, 2024

Uffizzi Ephemeral Environment deployment-55994

⌚ Updated Sep 07, 2024, 04:19 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2591

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza changed the title feat(ISSUE-2571): Add page size and current page index to data browser feat: Add page size and current page index to data browser Sep 17, 2024
@mtrezza
Copy link
Member

mtrezza commented Sep 17, 2024

Thank you for this PR; could you please:

  • take a look at the failing lint test in the CI
  • use UI elements in the style that the dashboard already uses; the new UI elements look different (font, color, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page size and current page index to data browser
2 participants