Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for visionOS #1762

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

bmueller
Copy link

@bmueller bmueller commented Oct 13, 2023

New Pull Request Checklist

  • [x ] I am not disclosing a vulnerability.
  • [x ] I am creating this PR in reference to an issue.

Issue Description

Adds visionOS support.

Closes: #1761

Approach

Just added TARGET_OS_VISION in a bunch of places. Also updated the readme to mention visionOS alongside the other supported platforms.

TODOs before merging

  • Add tests
  • [x ] Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 13, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dplewis
Copy link
Member

dplewis commented Oct 14, 2023

@bmueller Thank you for the PR, everything looks good so far! Waiting for #1763 to be merged to fix the CI and to prevent any merge conflicts with this PR.

The next steps would be:

  • Adding .visionOS(.v1) to Package.swift
  • Adding Badge to README
  • Adding a VisionOS starter project and building it in the Rakefile to run in the CI to ensure these changes work.
  • Possibly add PF_VISION_UNAVAILABLE and PF_VISION_UNAVAILABLE_WARNING as needed.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.24%. Comparing base (dd05d41) to head (492bba7).
Report is 3 commits behind head on master.

❗ Current head 492bba7 differs from pull request most recent head 21457a9. Consider uploading reports for the commit 21457a9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1762   +/-   ##
=======================================
  Coverage   64.24%   64.24%           
=======================================
  Files         201      201           
  Lines       23233    23233           
=======================================
+ Hits        14926    14927    +1     
+ Misses       8307     8306    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza
Copy link
Member

mtrezza commented Apr 6, 2024

@bmueller Would you want to add a visionOS job to the CI as well, so we can make sure it compiles?

@mtrezza mtrezza changed the title Add support for visionOS feat: Add support for visionOS Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visionOS support
3 participants