Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump crypto js #1416

Merged
merged 2 commits into from
Sep 24, 2021
Merged

fix: bump crypto js #1416

merged 2 commits into from
Sep 24, 2021

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 24, 2021

New Pull Request Checklist

Issue Description

crypto-js 4.0.0 requires manual polyfill when used with webpack 5 in Parse Dashboard, see brix/crypto-js#364.

Related issue: parse-community/parse-dashboard#1807 (comment)

Approach

Bump crypto-js to 4.1.1, which should fix the issue.

TODOs before merging

  • Add entry to changelog

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1416 (d03c379) into master (83fb442) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1416   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5943     5943           
  Branches     1350     1350           
=======================================
  Hits         5940     5940           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fb442...d03c379. Read the comment docs.

@mtrezza mtrezza merged commit ddea28c into parse-community:master Sep 24, 2021
@mtrezza mtrezza deleted the bump-crypto-js branch September 24, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant