Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm version ci check #1345

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Apr 14, 2021

Adds a CI check that requires package-lock.json to be generated with npm <7.

Building with npm 7 causes errors that are difficult to interpret.
The discussion in #1344 shows that without a clear error message, contributors and reviewers unnecessarily spend more time to trace the issue back to npm 7.

This is analogous to parse-community/parse-server#7333.

@mtrezza mtrezza requested a review from dplewis April 14, 2021 13:08
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1345 (f516dd9) into master (490c8c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f516dd9 differs from pull request most recent head d546e07. Consider uploading reports for the commit d546e07 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1345   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          60       60           
  Lines        5919     5920    +1     
  Branches     1346     1346           
=======================================
+ Hits         5874     5875    +1     
  Misses         44       44           
  Partials        1        1           
Impacted Files Coverage Δ
src/ParseError.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52cd8d4...d546e07. Read the comment docs.

@mtrezza mtrezza force-pushed the add-npm-version-CI-check branch from 0f81465 to d546e07 Compare April 14, 2021 13:14
@dplewis dplewis merged commit 16b45fd into parse-community:master Apr 14, 2021
@mtrezza mtrezza deleted the add-npm-version-CI-check branch October 26, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants