Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #992 #1018

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Fix #992 #1018

merged 1 commit into from
Dec 2, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 2, 2019

After much discussion the proper way to subclass is a user is Parse.Object.registerSubclass('_User', CustomUser);

Reverts #978

After much discussion the proper way to subclass is a user is `Parse.Object.registerSubclass('_User', CustomUser);`

Revert ##978
@dplewis dplewis changed the title Fix https://github.com/parse-community/Parse-SDK-JS/issues/992 Fix #992 Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1018 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files          53       53           
  Lines        5115     5115           
  Branches     1146     1145    -1     
=======================================
  Hits         4703     4703           
  Misses        412      412
Impacted Files Coverage Δ
src/ParseUser.js 82.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028273b...3a2526c. Read the comment docs.

@davimacedo davimacedo merged commit 3316ac9 into master Dec 2, 2019
@dplewis dplewis deleted the fix-992 branch December 2, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants