Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix umbrella test count #34

Merged
merged 2 commits into from
Jan 1, 2017

Conversation

luc-tielen
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 23, 2016

Coverage Status

Coverage increased (+2.2%) to 75.789% when pulling 82e8822 on luc-tielen:fix_umbrella_test_count into a876a73 on parroty:master.

@luc-tielen
Copy link
Contributor Author

Fixes #33.

Looks like tests in CI build fail because of following reason:
** (UndefinedFunctionError) undefined function: MapSet.new/1
when doing mix deps.get (package jsx)

(But when running locally they are fine for me.)
@parroty or @myronmarston can you re-run/verify manually?

@luc-tielen
Copy link
Contributor Author

So, any updates on this @parroty? Been almost a week now.
If the build failure is a problem, it's an error in hex for Elixir version 1.1.1, due to MapSet.new not being available there.
Maybe a separate issue should be created to fix it (and potentially add other more recent versions of Elixir too.)

@parroty parroty merged commit daea990 into parroty:master Jan 1, 2017
@parroty
Copy link
Owner

parroty commented Jan 1, 2017

Thanks and very sorry taking time to merge.

@luc-tielen
Copy link
Contributor Author

No problem, glad it got merged in :)

@luc-tielen luc-tielen deleted the fix_umbrella_test_count branch January 1, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants