Add support for PDP Mirror's Edge controller in xpad.c #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8BitDo Pro 2 Wired Controller shares the same USB identifier (2dc8:3106) as a different device, so amend name to reflect that and reduce confusion as the user might think the controller was misdetected. I have personally tested it and I can confirm that Pro 2 Wired will also not work in XTYPE_XBOXONE mode (buton presses won't register), therefore XTYPE_XBOX360 remains appropriate. Signed-off-by: Leonardo Brondani Schenkel <leonardo@schenkel.net>
Signed-off-by: Jack Greiner <jack@emoss.org>
I found that my controller wasn't working with this driver. The LED would light up and it could rumble but was not registering any button presses or joystick movements. I suspected the problem might be that it was not being sent some required init packet so I tried sending the packets being used in xboxone_init_packets and found that sending xboxone_pdp_auth got the controller working. At least for my controller xboxone_pdp_led_on was not strictly necessary but I decided to follow the same pattern used by the other two controllers.
Signed-off-by: Daniel Tobias <dan.g.tob@gmail.com>
Signed-off-by: Daniel Tobias <dan.g.tob@gmail.com> Signed-off-by: Jonathan <greenbigfrog@gmail.com> Signed-off-by: Matt Sturgeon <matt@sturgeon.me.uk>
This allows to turn off the pad without having to release the Xbox (mode) button Signed-off-by: Davide Garberi <dade.garberi@gmail.com>
This controller is a "Series S|X": it has the "share" button below the big Xbox button. However, it reports the status of that button in a different offset than the official controller. The button is still recognized by official Microsoft driver in Windows, so it looks like that both offsets are used in the wild. Signed-off-by: Leonardo Brondani Schenkel <leonardo@schenkel.net>
Many knockoff brands emulating the XBOX 360 controller do not properly send data unless configured correctly. Examples include the Gamesir G3w and the Fantech GP11 Shooter. Protocol inspection of communication with other operating systems reveals a sequence of control messages that can be used to initialize the controllers sufficiently to send proper data. Some of these controllers only require one and may break with further, some may require all three. This change adds a quirks field that allows specifying these initialization packets. Note that it also removes an unused field from the controller type table. Signed-off-by: Darvin Delgado <dnmodder@gmail.com> Signed-off-by: Vicki Pfau <vi@endrift.com>
Add support for PDP Mirror's Edge controller
Flatfire
changed the title
|
Bumping this a bit, along with some elaboration. This PDP XB1 controller is remarkably similar to others, but was a 5000 controller limited run. Not many people would be affected, but I happen to be one of them and this seems like a minor change with no impact to the rest of the codebase. Adding it to the official xpad release would be appreciated. |
paroj
force-pushed
the
master
branch
3 times, most recently
from
be77395 to
b27afdf
Compare
|
merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for PDP Mirror's Edge controller