Skip to content

Commit

Permalink
Input: xpad - add support for 8BitDo Ultimate Wireless controller dongle
Browse files Browse the repository at this point in the history 
Signed-off-by: Josh Cotton <jcotton42@outlook.com>
  • Loading branch information
@jcotton42
jcotton42 authored Nov 14, 2022
1 parent dbe7e09 commit 1821d28
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions xpad.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ static const struct xpad_device {
{ 0x24c6, 0xfafe, "Rock Candy Gamepad for Xbox 360", 0, XTYPE_XBOX360 },
{ 0x2563, 0x058d, "OneXPlayer Gamepad", 0, XTYPE_XBOX360 },
{ 0x2dc8, 0x2000, "8BitDo Pro 2 Wired Controller fox Xbox", 0, XTYPE_XBOXONE },
{ 0x2dc8, 0x3106, "8BitDo Ultimate Wireless Controller", 0, XTYPE_XBOX360 },
{ 0x31e3, 0x1100, "Wooting One", 0, XTYPE_XBOX360 },
{ 0x31e3, 0x1200, "Wooting Two", 0, XTYPE_XBOX360 },
{ 0x31e3, 0x1210, "Wooting Lekker", 0, XTYPE_XBOX360 },
Expand Down Expand Up @@ -512,6 +513,7 @@ static const struct usb_device_id xpad_table[] = {
XPAD_XBOX360_VENDOR(0x2563), /* OneXPlayer Gamepad */
XPAD_XBOX360_VENDOR(0x260d), /* Dareu H101 */
XPAD_XBOXONE_VENDOR(0x2dc8), /* 8BitDo Pro 2 Wired Controller for Xbox */
XPAD_XBOX360_VENDOR(0x2dc8), /* 8BitDo Ultimate Wireless Controller */
XPAD_XBOXONE_VENDOR(0x2e24), /* Hyperkin Duke X-Box One pad */
XPAD_XBOX360_VENDOR(0x2f24), /* GameSir Controllers */
XPAD_XBOX360_VENDOR(0x31e3), /* Wooting Keyboards */
Expand Down

4 comments on commit 1821d28

@btegs
Copy link
Contributor

@btegs btegs commented on 1821d28 Dec 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paroj and @jcotton42 - Are you going to eventually push this to the main Linux kernel?

I also see the 8bitdo Pro 2 is setup as an Xbox One controller while the Ultimate is Xbox 360. Was this intentional to offer better compatibility? I ask because the Ultimate has an extra share button associated with the Xbox One.

@jcotton42
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the Pro 2, but I added the Ultimate as an 360 controller because that's how it showed up when connected on Windows.

As for mainlining, I don't know how the xpad devs handle it, I assume they just do that on a semi-regular basis, but that assumption admittedly isn't based on anything.

@btegs
Copy link
Contributor

@btegs btegs commented on 1821d28 Dec 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the Pro 2, but I added the Ultimate as an 360 controller because that's how it showed up when connected on Windows.

As for mainlining, I don't know how the xpad devs handle it, I assume they just do that on a semi-regular basis, but that assumption admittedly isn't based on anything.

Thanks for the response. Makes sense to have the Ultimate as an Xbox 360 if the device shows like that. Probably good to leave the Pro 2 as-is since it is already active in the 6.x kernels.

@btegs
Copy link
Contributor

@btegs btegs commented on 1821d28 Dec 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcotton42 and @paroj - I got the Ultimate Controller today (2.4g only with Xbox controller buttons) and noticed a conflict and created an issue: #228

I don't know if this is something that has to be handled on 8bitdo's end as prior controllers would sync as either an Xbox 360 or Xbox One controller using the Microsoft ids.

Please sign in to comment.