Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add drop down menu for commands #5

Merged
merged 3 commits into from
Nov 29, 2023
Merged

add drop down menu for commands #5

merged 3 commits into from
Nov 29, 2023

Conversation

firezym
Copy link
Contributor

@firezym firezym commented Nov 28, 2023

  1. add button (original split cell extension style) and a drop down menu for commands using menu of lumino widgets
  2. optimize the desription for commands

Already test it by uninstalling and re-installing from git remote repo as a clean start. Pls check and test it further.

image

add drop down menu for commands
@firezym
Copy link
Contributor Author

firezym commented Nov 28, 2023

Totally no clue what's wrong. It worked fine in my env. Please help to check and feel free to change anything by commit @parmentelat
image

@parmentelat
Copy link
Owner

just run jlpm run lint and commit any change

fix lint issue
@firezym
Copy link
Contributor Author

firezym commented Nov 28, 2023

Passed the check and seems ok now.

@parmentelat parmentelat merged commit 6c65936 into parmentelat:main Nov 29, 2023
3 checks passed
@parmentelat
Copy link
Owner

thanks, will issue a new release shortly

@parmentelat
Copy link
Owner

0.1.4 is up at pypi !

@parmentelat
Copy link
Owner

and fyi in just released 0.1.5 one can turn the button off or on through the settings editor

@firezym
Copy link
Contributor Author

firezym commented Nov 30, 2023

Cool !

@parmentelat
Copy link
Owner

parmentelat commented Dec 1, 2023

it took me some trial and error cycles to finally get it right wrt multiple notebooks opened at the same time
(the settings business was far from crucial, I'm just using this as an opportunity to deepen my knowledge about jlab extensions)

hopefully version 0.2.1 should be quite fine now, please try to shake it up as much as you can :-)

I know of one remaining issue #7, so if you see it and can help pinpoint how to reproduce, please comment on that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants