feat: added the gitlab cleanup code #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0r1s
approved these changes
Jan 19, 2024
scripts/gitlab_cleanup/main.go
Outdated
Comment on lines
17
to
18
| fmt.Printf("Error creating in-cluster config: %s\n", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("Error creating in-cluster config: %s\n", err) | |
| os.Exit(1) | |
| log.Fatalf("Error creating in-cluster config: %s\n", err) |
scripts/gitlab_cleanup/main.go
Outdated
Comment on lines
23
to
24
| fmt.Printf("Error creating clientset: %s\n", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("Error creating clientset: %s\n", err) | |
| os.Exit(1) | |
| log.Fatalf("Error creating clientset: %s\n", err) |
scripts/gitlab_cleanup/main.go
Outdated
Comment on lines
31
to
32
| fmt.Printf("Error listing pods: %s\n", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf("Error listing pods: %s\n", err) | |
| os.Exit(1) | |
| log.Fatalf("Error listing pods: %s\n", err) |
l0r1s
reviewed
Jan 19, 2024
scripts/gitlab_cleanup/main.go
Outdated
| } | ||
|
|
||
| for _, pod := range pods.Items { | ||
| if time.Since(pod.CreationTimestamp.Time).Hours() > 12 { |
There was a problem hiding this comment.
We could probably extract a const, maybe having it in the env to make this configurable without having to change the code ? Wdyt ?
There was a problem hiding this comment.
Yes, I think an env var with a default value could be better.
emamihe
changed the title
emamihe
force-pushed
the
gitlab-cleaner
branch
from
a02f246
to
41b0b16
Compare
l0r1s
reviewed
Jan 30, 2024
Comment on lines
+28
to
+33
| podAgeThresholdHours := 12 // default | ||
| if envVal, exists := os.LookupEnv("POD_AGE_THRESHOLD_HOURS"); exists { | ||
| if val, err := strconv.Atoi(envVal); err == nil { | ||
| podAgeThresholdHours = val | ||
| } | ||
| } |
l0r1s
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this golang code will cleanup the github stalled runners