Install procps in Zombienet docker image #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se native provider inside docker
svyatonik
requested review from
pepoviola,
wirednkod and
l0r1s
as code owners
|
Hi @svyatonik thanks for your contribution, what is stopping you from running multiple local zombienet processes with differents TOML configuration (without the docker injected zombienet) ? |
l0r1s
approved these changes
Jan 11, 2024
pepoviola
approved these changes
Jan 11, 2024
We're going to run it on CI, so we are preparing a image based on yours with all required binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: if you'll try to use native provider inside this image (we do that, because we need to deploy multiple relay chains and there's no support for that in other providers), spawn will fail with the "At least one of the nodes fails to start" error. The reason is that the native provider uses the
pshere and it is unavailable in the Docker image.This isn't critical for us, because we're building image on top of base Zombienet image, but perhaps it'll be useful for other users as well.