Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-runner): add import into try/catch and show error and stack … #1615

Merged
merged 3 commits into from
Dec 22, 2023
Merged

fix(test-runner): add import into try/catch and show error and stack … #1615

merged 3 commits into from
Dec 22, 2023

Conversation

pepoviola
Copy link
Collaborator

@pepoviola pepoviola commented Dec 22, 2023 •
edited
Loading

…on debug

fix #1608

cc: @mrcnski

mrcnski
mrcnski approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thank you!

javascript/packages/orchestrator/src/test-runner/assertions.ts Outdated Show resolved Hide resolved
@pepoviola @mrcnski
Update javascript/packages/orchestrator/src/test-runner/assertions.ts
903d995 
Co-authored-by: Marcin S. <marcin@realemail.net>
@pepoviola pepoviola merged commit 82a9629 into main Dec 22, 2023
23 checks passed
@pepoviola pepoviola deleted the fix-1608-show-err branch December 22, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcnski mrcnski mrcnski approved these changes

@wirednkod wirednkod Awaiting requested review from wirednkod

@l0r1s l0r1s Awaiting requested review from l0r1s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report javascript parse errors
2 participants
@pepoviola @mrcnski