Fix race conditions with getRandomPort by storing previous ports #1171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes when starting a network with many parachains, one of the nodes seems to fail to start, with the following error seen in the zombienet logs repeatedly:
After inspecting the node logs, it turns out that the prometheus port of one node was being used as the rpc port of another node. Surprisingly, that random port was assigned by zombienet, as you can see in the yaml files:
So that error can be avoided by storing the ports returned by the
getRandomPort
function, and ensuring that it doesn't return the same port twice. So that's what is done in this PR, and I have verified it fixes the problem.