Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params for delay in k8s #1147

Merged
merged 49 commits into from
Sep 3, 2023
Merged

Add params for delay in k8s #1147

merged 49 commits into from
Sep 3, 2023

Conversation

wirednkod
Copy link
Contributor

@wirednkod wirednkod commented Jun 26, 2023

Fixes #927

@pepoviola
Copy link
Collaborator

Hey @wirednkod, this will not works since we need to deploy a NetworkChaos manifest (with the right selectors) to affect pods/namespace. Take a look at this issue #1092 for examples of those manifests.

Ping me tested if you want. Thanks!!

@wirednkod wirednkod marked this pull request as ready for review August 21, 2023 13:16
@wirednkod wirednkod requested a review from l0r1s as a code owner August 21, 2023 13:16
@pepoviola
Copy link
Collaborator

@wirednkod, I added a new test for our ci and fix an issue in the chaos manifest. I think this is ready to go ones the ci finish.

Thanks!

@wirednkod wirednkod requested a review from pepoviola August 30, 2023 13:03
@pepoviola
Copy link
Collaborator

Hi @wirednkod, I will refactor this since applying the delay when we create the pods cause performance issues with the spawn of the network. I will change the logic to spawn the network and apply all the manifest at once before returning the network instance.

@wirednkod
Copy link
Contributor Author

Hi @wirednkod, I will refactor this since applying the delay when we create the pods cause performance issues with the spawn of the network. I will change the logic to spawn the network and apply all the manifest at once before returning the network instance.

Thank you @pepoviola

@pepoviola
Copy link
Collaborator

Delay test is now green @wirednkod, I think we can merge this on as is. I will open a new issue to support add/remove delays as part of the zndsl.
Thx!

@pepoviola
Copy link
Collaborator

@wirednkod merging now, and I created this followup issue #1302

We should also add the docs for this settings in the spawn phase.

@pepoviola pepoviola merged commit 84d83f3 into main Sep 3, 2023
@pepoviola pepoviola deleted the nik-add-delay-params branch September 3, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[infra] Simulate bad network conditions
2 participants