Skip to content

Commit

Permalink
Fixing gitspiegel trigger workflow
Browse files Browse the repository at this point in the history
The first attept to use a workflow to protect GitLab CI from untrusted contributors failed, because GitHub doesn't pass secrets to workflows for PRs that originate from forks. 
 
This uses a different approach: instead of triggerring gitspiegel API directly from the workflow, we're just spawning an empty workflow with a specific path, and gitspiegel listens for `workflow_run` event to start mirroring.  

The idea is the same: for the first-time contributors, running workflows would require manual aciton and that would block mirroring. But this time, we don't need any secrets to make it work.
  • Loading branch information
mutantcornholio authored and pepoviola committed Nov 7, 2023
1 parent 5ad9359 commit 224ad92
Showing 1 changed file with 20 additions and 18 deletions.
38 changes: 20 additions & 18 deletions .github/workflows/gitspiegel-trigger.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
# name: gitspiegel sync
name: gitspiegel sync

# on:
# pull_request:
# types:
# - opened
# - synchronize
# - unlocked
# - ready_for_review
# - reopened
# This workflow doesn't do anything, it's only use is to trigger "workflow_run"
# webhook, that'll be consumed by gitspiegel
# This way, gitspiegel won't do mirroring, unless this workflow runs,
# and running the workflow is protected by GitHub

# jobs:
# sync:
# runs-on: ubuntu-latest
# steps:
# - name: Trigger sync via API
# run: |
# curl --fail-with-body -XPOST "https://gitspiegel.parity-prod.parity.io/api/v1/mirror/${{ github.repository }}/pull/${{ github.event.number }}" \
# -H "Content-Type: application/json" \
# -H "x-auth: ${{ secrets.GITSPIEGEL_TOKEN }}"
on:
pull_request:
types:
- opened
- synchronize
- unlocked
- ready_for_review
- reopened

jobs:
sync:
runs-on: ubuntu-latest
steps:
- name: Do nothing
run: echo "let's go"

0 comments on commit 224ad92

Please sign in to comment.