-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage check in each pr #88
Conversation
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Hi @muraca, Thanks for working on this 👍. I think something like this will work. - name: Setup LCOV
uses: hrishikesh-kadam/setup-lcov@v1
- name: Report code coverage
uses: zgosalvez/github-actions-report-lcov@v3
with:
coverage-files: lcov.*.info
artifact-name: code-coverage-report
github-token: ${{ secrets.GITHUB_TOKEN }}
update-comment: true Thanks! |
@pepoviola you noticed too fast, sorry if I'm making a mess but I noticed too late that I opened a PR on this repo instead of my personal one. I didn't want to add more bloat by installing lcov too, it is used to create an html file we don't need here, and that's why I moved from Now I get a 404 error because the action makes a GET request to |
Hi @muraca, I fixed the request (the issue was related on how to get the
|
Looks like some permissions are missing. |
Signed-off-by: muraca <mmuraca247@gmail.com>
CI run for dummy pull request. |
Hi @muraca, great! Yes, I wonder if the permission issue is related to be a |
Happy to help! |
Thanks @muraca ! 🚀 |
fix #86