Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add warn when a raw chain-spec is provided #223

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

pepoviola
Copy link
Collaborator

  • resolve todo

Copy link

github-actions bot commented Jun 3, 2024

Coverage after merging fix-provide-chain-spec-raw into main

51.04%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
crates/configuration/src
   global_settings.rs100%100%100%100%
   hrmp_channel.rs100%100%100%100%
   network.rs98.88%100%100%98.78%118, 123, 131, 178, 81, 89
   parachain.rs93.95%100%96.88%93.68%372–384, 386–393, 396, 46–47, 60–62, 651–660, 76–79
   relaychain.rs94.12%100%96.88%93.82%383–392, 93–95
   utils.rs50%100%50%50%15–17, 19–21, 23–25
crates/configuration/src/shared
   errors.rs100%100%100%100%
   helpers.rs100%100%100%100%
   node.rs95.85%100%96.88%95.77%119, 136, 142, 388–406, 408, 44
   resources.rs97.10%100%97.56%97.04%102, 114, 126–128, 147–150
   types.rs94.81%100%92.31%95.22%284–286, 355–357, 383–384, 386–388, 407, 60–62
crates/file-server/src
   main.rs0%100%0%0%22–49, 51–58, 60–61, 63–65, 67–70, 72–73, 75, 77–81, 83–88
crates/orchestrator/src
   errors.rs0%100%0%0%8
   lib.rs24.18%100%35.14%23.28%100–101, 103–110, 112, 114–119, 121–125, 128–129, 131, 135–152, 156–183, 187–196, 199–203, 206–210, 212, 214–218, 221–239, 241–246, 248–268, 270, 272–274, 278–280, 283, 286–291, 293–296, 299–303, 306, 308–309, 312–316, 318, 320–334, 337–339, 341–346, 356–380, 385–386, 395, 406, 414–417, 419, 438–440, 442–452, 454–455, 457–465, 467–474, 476–479, 48, 480–483, 485–489, 49, 490–496, 50–53, 55–60, 62–69, 71–76, 79–85, 88–91, 93, 96–97, 99
   network.rs0%100%0%0%121–131, 133–134, 136–140, 143–149, 151–152, 154–157, 160–178, 180, 193–196, 223–236, 238, 240–250, 252–266, 268–269, 271–275, 278–281, 283–290, 292, 295–300, 302–303, 305–308, 311–317, 323–326, 361–366, 368–372, 375, 377–379, 38, 380–382, 384–389, 39, 390–392, 395–397, 40, 400–401, 403, 406, 408–409, 41, 410–419, 42, 420–425, 427–429, 43, 432–436, 438, 44, 440–444, 449, 45, 450–459, 46, 460–483, 486–489, 491–496, 498–499, 504–520, 522–530, 532–534, 536–538, 541–545, 547, 549–551, 553–555, 557–559, 561–563, 565–567, 569–571, 573–578, 580–586, 59–73, 76–78, 80–82, 84–86, 89–91
   network_spec.rs39.27%100%33.33%39.92%100–105, 108–111, 114–120, 123–124, 127–138, 141–157, 160–164, 166–169, 171–195, 197–206, 208–210, 212, 47, 63–70, 72–74, 76–82, 85–93, 96–98
   pjs_helper.rs0%100%0%0%10–13, 15, 17, 21, 24–45, 49–52, 54–59, 6, 60–63, 7–9
   spawner.rs0%100%0%0%101–106, 108–111, 114–123, 125, 128–130, 133–137, 139, 144–148, 151, 153–157, 159–163, 166–176, 178–179, 181, 185–188, 190–195, 197–207, 209–212, 215–216, 219–223, 226, 228, 230–237, 44–57, 59–60, 62, 64–67, 71–72, 74, 77–97, 99
crates/orchestrator/src/generators
   bootnode_addr.rs96.94%100%100%96.67%
   chain_spec.rs23.84%100%20%24.12%100, 1000–1001, 1004–1006, 1008, 1011, 1013, 107–110, 114, 128–144, 146–159, 161, 165–170, 174, 176, 179, 182–186, 188–192, 194, 196–198, 200, 203–204, 208–219, 221–226, 228–237, 240–257, 260–266, 268–270, 272–277, 279, 282–290, 292–296, 298, 300, 302, 304, 307–317, 320–323, 325–327, 329–338, 340–352, 354, 357–362, 364–365, 367–380, 382, 385–390, 392–393, 396–409, 411–416, 418–420, 422–424, 427–431, 433–455, 459–468, 471–474, 476, 478–479, 481–489, 49, 490–496, 498, 50, 500–504, 506, 509, 51, 512–513, 516–519, 52, 520, 523–529, 53, 530–547, 551–553, 556–564, 574–582, 584–596, 598–606, 609–611, 615–618, 620–621, 624–631, 633–635, 638–640, 642, 647–653, 656–668, 670–677, 679–684, 686, 688–699, 703–716, 718, 721–722, 725–731, 733–738, 740–745, 747, 749, 751–760, 762–765, 768–769, 772–774, 776, 778–779, 781–785, 787–790, 792, 794–795, 797–798, 800–802, 804–806, 808–810, 813–815, 818–822, 824, 826, 845, 869, 873–879, 881–891, 893–894, 896–916, 918, 931, 935–939, 94, 940–949, 95, 950–957, 959, 96, 968–978, 98, 980, 982–989, 99, 990–999
   command.rs0%100%0%0%100–106, 109–121, 123–129, 131, 134–139, 141, 144–157, 159, 162–164, 166, 169, 17, 170–179, 18, 180–189, 19, 190–199, 20, 200–206, 208, 21, 210, 212–219, 22, 220–229, 23, 230–233, 235–238, 24, 240–245, 247–249, 25, 250–255, 258–259, 26, 260–268, 27, 270–274, 276, 279–287, 289, 292–308, 311–316, 318, 321–323, 325, 328–348, 350–352, 354–355, 357, 359, 362–364, 366, 368, 47–65, 67–69, 71–79, 82–99
   errors.rs0%100%0%0%4
   identity.rs81.25%100%50%85.71%13
   key.rs93.97%100%72.73%96.19%36
   keystore.rs0%100%0%0%19–31, 34–46, 48–55, 57–64, 66, 68–86
   para_artifact.rs19.77%100%40%18.52%100–105, 107, 110–116, 118, 121–131, 135–136, 54–56, 58–72, 74–77, 81–82, 84, 86–96, 98
   port.rs93.33%100%75%96.15%
crates/orchestrator/src/network
   node.rs0%100%0%0%101–106, 116–123, 127–135, 138–140, 142, 146–148, 156–166, 169–170, 178–186, 188–190, 193–194, 196–202, 204–206, 208–211, 213–217, 221–229, 27–42, 44–46, 48–50, 52–54, 56–58, 62–65, 68–70, 73–77, 79, 81, 85–88, 91–94
   parachain.rs60.37%100%64.29%60.10%100–105, 108–119, 121, 123, 126–131, 134–135, 137–142, 146–149, 153–157, 159–162, 164, 168–169, 171–173, 175–177, 179–181, 66, 69–74, 76–83, 93–97
   relaychain.rs0%100%0%0%14–21, 24–26, 28–30
crates/orchestrator/src/network_helper
   verifier.rs0%100%0%0%10–12, 17, 19–25, 27–32, 34, 8–9
crates/orchestrator/src/network_spec
   node.rs33.11%100%14.29%34.03%127–128, 130–133, 147, 158–159, 193–197, 199–200, 202, 205, 207–210, 212–215, 218, 222–227, 229, 232, 234–259, 26, 260–266, 268, 27, 270–277, 279, 28, 280–281, 29–38
   parachain.rs63.64%100%66.67%63.50%107, 112, 122, 152, 157–160, 163, 175–178, 181, 220–233, 235–247, 249, 251–252, 79, 84–86, 98
   relaychain.rs94.74%100%100%94.29%112, 119, 79, 86
crates/orchestrator/src/shared
   types.rs66.67%100%66.67%66.67%45–49
crates/prom-metrics-parser/src
   lib.rs93.22%100%85.71%93.69%103, 125, 53–55, 7, 79
crates/provider/src
   lib.rs0%100%0%0%142–145, 147–150, 199–201, 208–210, 25
crates/provider/src/docker
   client.rs0%100%0%0%100, 103–109, 11, 110–122, 124–134, 136–147, 149–155, 157–163, 165–168, 170–173, 175–178, 182–183, 185–186, 188–190, 192, 194, 196–200, 203–212, 214–215, 219–221, 223–229, 231–240, 242–248, 250–252, 254–260, 262–273, 275–281, 283–289, 291–302, 304–315, 317–321, 323–325, 327–336, 338–348, 350–358, 360–380, 382–392, 394–400, 402–411, 413–419, 42, 420–424, 426, 428–433, 435, 437–445, 447–448, 450–452, 454–462, 464–467, 469–472, 475–477, 479–485, 487–491, 494–495, 497–502, 504, 506–507, 509–510, 512–525, 529–530, 532–535, 537–539, 54, 541–545, 547–551, 554–556, 558–560, 562, 564–567, 65, 81–91, 93–99
   namespace.rs0%100%0%0%101–110, 112–122, 124–130, 132–143, 146–153, 155–162, 165–175, 177–178, 180–187, 190–211, 214–224, 226–227, 229–231, 233–235, 238, 240, 248–250, 252–254, 256–258, 260–262, 264–266, 268–275, 280–300, 302–331, 333–384, 386–388, 390–402, 409–431, 435–436, 438, 440–441, 50–61, 63–65, 68, 70–72, 75–87, 89–90, 92–96, 98–99
   node.rs0%100%0%0%100–119, 121–123, 125, 127, 129–130, 132–166, 169–178, 180–181, 183–187, 225–234, 236–237, 239–259, 261–262, 264–267, 270–272, 274–275, 277–296, 298–299, 301–306, 314–316, 318–320, 322–324, 326–328, 330–332, 334–336, 338–340, 342–344, 346–352, 354–358, 360–362, 364–366, 371–399, 404–406, 413–456, 462–464, 466–480, 482–500, 502–520, 522–544, 546–557, 73–78, 80–84, 86–91, 93, 98
   provider.rs0%100%0%0%100–113, 118–135, 34–55, 57–58, 62–66, 68–71, 79–81, 83–85, 87–94, 96–99
crates/provider/src/kubernetes
   client.rs0%100%0%0%100–101, 103–134, 136, 138–139, 141–163, 165–172, 174–176, 178–190, 192–196, 198–202, 205–227, 229, 231–247, 249–259, 26, 260–264, 266–271, 274–278, 280, 282–283, 286–287, 289–305, 308–310, 312, 317, 320, 323, 325–330, 332–338, 340–341, 343–366, 368–369, 373–379, 38, 380–389, 39, 390–399, 40, 400–409, 41, 411–413, 416–419, 42, 420–429, 43, 430, 432–444, 446–447, 449, 45, 450–462, 464–477, 48, 481–482, 49, 492–499, 50, 500–509, 51, 510, 52–53, 56–64, 66–85, 87, 89–90, 92–98
   namespace.rs0%100%0%0%100–102, 104–111, 113–120, 122–123, 125–140, 142–148, 150–152, 154–159, 162–166, 168–180, 183–193, 195–230, 232–236, 239–240, 242–249, 251–258, 260–264, 266–267, 269–276, 278–282, 284–285, 287–288, 290–309, 311–313, 315–319, 321–322, 324–326, 328–330, 333, 335, 342–353, 355–358, 360–361, 369–371, 373–375, 377–379, 381–383, 385–387, 389–396, 401–422, 424–452, 454–505, 507–509, 511–523, 56–67, 69–71, 74, 76–78, 81–95, 97–98
   node.rs0%100%0%0%100, 105, 107–127, 129–131, 133, 135, 137–138, 140–160, 162–166, 168–169, 171–179, 182–207, 209–213, 215–216, 218–225, 227–228, 230–237, 242–266, 268–269, 271–280, 282–283, 285–304, 306–307, 309–312, 315–317, 319–320, 322–340, 342–343, 345–350, 352–359, 361–364, 366–369, 371, 373–381, 383–384, 386–391, 393–396, 404–406, 408–410, 412–414, 416–418, 420–422, 424–426, 428–430, 432–434, 436–438, 440–444, 447–452, 454–463, 469–487, 492–519, 524–540, 547–615, 621–623, 625–646, 648–665, 667–684, 686–707, 709–720, 80–85, 87–91, 93–98
   pod_spec_builder.rs0%100%0%0%100–125, 127–149, 15, 150–152, 154–159, 16, 160–166, 168–169, 17, 170–172, 174–176, 178–179, 18, 180, 182–183, 185, 187, 19–32, 34–71, 73–90, 92–99
   provider.rs0%100%0%0%102–119, 34–50, 52–55, 63–65, 67–69, 71–78, 80–97
crates/provider/src/native
   namespace.rs0%100%0%0%100–101, 106–124, 126–151, 153–209, 211–214, 216–226, 41–51, 53–55, 58, 60–62, 65–74, 82–84, 86–88, 90–92, 94–99
   node.rs0%100%0%0%100–103, 108–109, 111–131, 133–135, 137, 139, 141–142, 144–152, 154–155, 157–168, 170–171, 173–177, 180–184, 188–190, 192–193, 195–203, 205–215, 217–219, 221–222, 226–227, 229–232, 234–258, 260–279, 281, 283, 285, 287–288, 290–297, 300, 302–303, 305–306, 308–310, 314–315, 317–324, 326–327, 329–357, 359–360, 362–367, 375–377, 379–381, 383–385, 387–389, 391–393, 395–397, 399–401, 403–405, 407–413, 415–422, 424–426, 428–430, 435–458, 463–497, 504–529, 535–547, 549–556, 558–565, 567–584, 586–596, 84–93, 95–99
   provider.rs0%100%0%0%101–117, 33–50, 52–55, 63–65, 67–69, 71–78, 80–96
crates/provider/src/shared
   helpers.rs100%100%100%100%
   types.rs4%100%2.86%4.17%100–110, 112–118, 120–130, 132–135, 147–158, 160–167, 169–179, 192–202, 204–218, 220–226, 228–234, 236–239, 250–259, 261–268, 270–280, 290–299, 301–308, 310–320, 344–350, 354–361, 55–71, 73–79, 81–84, 86–89, 91–98
crates/sdk/src
   lib.rs0%100%0%0%36–41, 43–48, 50–55
crates/support/src
   fs.rs100%100%100%100%
   net.rs0%100%0%0%10, 4–9
   replacer.rs96.67%100%85.71%98.11%
crates/support/src/fs
   in_memory.rs96.66%100%95.56%96.74%248–253, 41–44, 46, 48–51, 53, 55–58, 60
   local.rs99.27%100%98.04%99.40%92–94

@pepoviola pepoviola merged commit b675655 into main Jun 3, 2024
6 checks passed
@pepoviola pepoviola deleted the fix-provide-chain-spec-raw branch June 3, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant