Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

stack_height: if instruction should pop one value from the stack #147

Merged
merged 2 commits into from
Apr 21, 2021
Merged

stack_height: if instruction should pop one value from the stack #147

merged 2 commits into from
Apr 21, 2021

Conversation

athei
Copy link
Member

@athei athei commented Apr 21, 2021

The current code does not consider that the if pops one argument from the stack on entering. See the added test which fails without this fix.

@athei athei added the bug label Apr 21, 2021
@athei athei requested a review from pepyakin April 21, 2021 11:25
pepyakin
pepyakin approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/stack_height/max_height.rs Outdated Show resolved Hide resolved
@athei athei merged commit b2272f3 into master Apr 21, 2021
@athei athei deleted the at-fix-stack-height branch April 21, 2021 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pepyakin pepyakin pepyakin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athei @pepyakin