feat: add asCallsOnlyArg to reduce size of metadata #149
Conversation
| true | ||
| ); | ||
|
|
||
| it('Metadata should decrease in byte size when `asCallsOnlyArg` is true with `createMetadataUnmemoized`', () => { |
There was a problem hiding this comment.
For the curious the reason we are testing both the unmemoized and memoized createMetadata is because if the length option for memoizee is changed to less than 3 the function will break for the asCallsOnlyArg, but createMetadataUnmemoized will still work with asCallsOnlyArg. I wanted to isolate them both so we can make sure in the future if any changes are made to either it still works as is for both.
| */ | ||
| export const createMetadata = memoizee(createMetadataUnmemoized, { | ||
| length: 2, | ||
| length: 3, |
There was a problem hiding this comment.
briefly reading over the docs (https://github.com/medikoo/memoizee#arguments-length), I wonder if this would work: "Dynamic length behavior can be forced by setting length to false, that means memoize will work with any number of arguments."
I am also a little confused how default args work in terms of length because of this note "Parameters predefined with default values (ES2015+ feature) are not reflected in function's length, therefore if you want to memoize them as well, you need to tweak length setting accordingly".
Either way though sounds like this works, so maybe not worth looking into
There was a problem hiding this comment.
It works with both false, and length 3 🤔 . false being more flexible, and 3 being strict but with a default arg. I do like the the idea of being strict with 3 though.
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
…ore into tarik-asCallsOnly
| const { metadataRpc, registry } = options; | ||
| registry.setMetadata(createMetadata(registry, metadataRpc)); | ||
| const { metadataRpc, registry, asCallsOnlyArg } = options; | ||
| registry.setMetadata(createMetadata(registry, metadataRpc, asCallsOnlyArg)); |
There was a problem hiding this comment.
Nit/Question: Why the suffix "Arg"?
There was a problem hiding this comment.
The idea being that asCallsOnly is the name of the getter for the metadata in polkadot-js so I wanted to make it have a separate name to reduce confusion.
| @@ -45,7 +45,26 @@ async function main(): Promise<void> { | |||
| 'state_getRuntimeVersion' | |||
| ); | |||
|
|
|||
| // Create Polkadot's type registry. | |||
| /** | |||
| * Create Polkadot's type registry. | |||
There was a problem hiding this comment.
@emostov This is what i wrote for the examples. Let me know if you think there should be more than this.
rel: #111
adds
asCallsOnlyArgas an option forgetRegistryBaseto reduce the size of the metadata.Todo: