-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tidext
in real world usage
#508
Conversation
Signed-off-by: David Lemarier <david@lemarier.ca>
Dumb question maybe, but could you point me to the usage of subxt in that project; I can't find anything offhand (https://github.com/iotaledger/stronghold.rs/search?q=subxt)? |
Hey @jsdw , this is not a dumb question! This is the Stronghold signer integration: The documentation is available here as well; Hope this help |
Aha, thanks guys, confusion cleared up :) (I would be curious to know why you forked Subxt though! Was it missing some crucial features?) |
README.md
Outdated
@@ -108,6 +108,7 @@ Please add your project to this list via a PR. | |||
- [phala-pherry](https://github.com/Phala-Network/phala-blockchain/tree/master/standalone/pherry) The relayer between Phala blockchain and the off-chain Secure workers. | |||
- [crunch](https://github.com/turboflakes/crunch) CLI to claim staking rewards in batch every Era or X hours for substrate-based chains. | |||
- [interbtc-clients](https://github.com/interlay/interbtc-clients) Client implementations for the interBTC parachain; notably the Vault / Relayer and Oracle. | |||
- [tidext](https://github.com/tidelabs/tidext) Tidechain client with [Stronghold](https://github.com/iotaledger/stronghold.rs) signer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be sufficient to add Stronghold
here, I think tidext
will cause confusion.
I guess you need some tweaks to subxt, perhaps you are using some other polkadot/substrate tags or what it's the reason behind the fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, thanks for review!
The main reason is that we need to have substrate locked to the same version that our chain and our primitives as they are shared between different services.
Once we stabilize everything, we should be good to use the same substrate version that subxt
use and delete the fork.
There is no missing features in subxt
, we had some previously but you guys fixed them all!
PS; I removed the Stronghold
link to prevent any confusion
Thanks again!
Signed-off-by: David Lemarier <david@lemarier.ca>
Signed-off-by: David Lemarier david@lemarier.ca