Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog script for consistent PR links #482

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix changelog script for consistent PR links #482

merged 1 commit into from
Mar 21, 2022

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Mar 21, 2022

We have noted during the release preparation (#481 ) that the script utilized for generating the changelog can result in inconsistent links.

Generated

- Return events from blocks skipped over during Finalization, too ([#473](git@github.com:paritytech/subxt/pull/473))

Expected

- Return events from blocks skipped over during Finalization, too ([#473](https://github.com/paritytech/subxt/pull/473))

The issue is related to how the pull request link is parsed.
For now, place a hardcoded link for uniform changelogs.

Testing Done

  • ./scripts/generate_changelog.sh
[+] Latest release tag: v0.18.1
[+] Changelog

- Use RPC call to get account nonce ([#476](https://github.com/paritytech/subxt/pull/476))
- Generate release changelog based on commits ([#465](https://github.com/paritytech/subxt/pull/465))
- Update README ([#472](https://github.com/paritytech/subxt/pull/472))
- Return events from blocks skipped over during Finalization, too ([#473](https://github.com/paritytech/subxt/pull/473))
- Make EventSubscription and FilterEvents Send-able ([#471](https://github.com/paritytech/subxt/pull/471))
  • shellcheck ./scripts/generate_changelog.sh

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@jsdw jsdw requested a review from a team March 21, 2022 13:47
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lexnv lexnv merged commit d941573 into master Mar 21, 2022
@lexnv lexnv deleted the gen_changelog branch March 21, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants