Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: substrate runner, support new libp2p addr log #1892

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: substrate runner, support new libp2p addr log #1892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions testing/substrate-runner/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,10 @@ fn try_find_substrate_port_from_output(r: impl Read + Send + 'static) -> Substra

// Parse the p2p port line (present in debug logs)
let p2p_port_line = line
// oldest message:
.rsplit_once("New listen address: /ip4/127.0.0.1/tcp/")
// slightly newer message:
.or_else(|| line.rsplit_once("New listen address address=/ip4/127.0.0.1/tcp/"))
Copy link
Member Author

@niklasad1 niklasad1 Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: ok I see, it comes from libp2p_tcp, probably this crate was bumped in polkadot-sdk

.map(|(_, address_str)| address_str);

if let Some(line_port) = p2p_port_line {
Expand Down
Loading