Make the codegen more accessible for running in WASM #1154

tadeohepperle · 2023-09-08T10:11:02Z

This PR makes some adjustments in subxt-codegen to make it WASM-compilable.

added a fetch_metadata feature flag (enabled by default, when disabled, no jsonrpsee, frame-metadata and tokio are needed as dependencies anymore which makes it easier to compile to WASM)
added a utility function value_ty on storage entries, which makes the code more concise in a few places.
expose types() function on the RuntimeTypeGenerator to have easier access to the metadata.

lexnv · 2023-09-12T09:18:39Z

metadata/src/lib.rs

@@ -395,6 +395,23 @@ pub enum StorageEntryType {
    },
 }

+impl StorageEntryType {
+    /// returns the type of the value.


small nit: Could start with uppercase here to be consistent with docs / fn below

lexnv · 2023-09-12T09:20:24Z

metadata/Cargo.toml

@@ -14,7 +14,9 @@ homepage.workspace = true
 description = "Command line utilities for checking metadata compatibility between nodes."

 [dependencies]
-codec = { package = "parity-scale-codec", workspace = true, features = ["derive"] }
+codec = { package = "parity-scale-codec", workspace = true, features = [
+    "derive",


dq: I do like the prior formatting more since I find one-liners easier to follow. Did you find any good formatters for .toml or its just personal preference?

Oh, I use the Even Better TOML VSCode extension for formatting. Let me revert it.

@tadeohepperle can you fix this as well?

codegen/Cargo.toml

codegen/src/api/mod.rs

codegen/src/types/mod.rs

codegen/src/api/storage.rs

Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.66 to 1.0.67. - [Release notes](https://github.com/dtolnay/proc-macro2/releases) - [Commits](dtolnay/proc-macro2@1.0.66...1.0.67) --- updated-dependencies: - dependency-name: proc-macro2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.106 to 1.0.107. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.106...v1.0.107) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [trybuild](https://github.com/dtolnay/trybuild) from 1.0.84 to 1.0.85. - [Release notes](https://github.com/dtolnay/trybuild/releases) - [Commits](dtolnay/trybuild@1.0.84...1.0.85) --- updated-dependencies: - dependency-name: trybuild dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from 2.6.2 to 2.7.0. - [Release notes](https://github.com/swatinem/rust-cache/releases) - [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md) - [Commits](Swatinem/rust-cache@e207df5...a95ba19) --- updated-dependencies: - dependency-name: Swatinem/rust-cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [jsonrpsee](https://github.com/paritytech/jsonrpsee) from 0.20.0 to 0.20.1. - [Release notes](https://github.com/paritytech/jsonrpsee/releases) - [Changelog](https://github.com/paritytech/jsonrpsee/blob/v0.20.1/CHANGELOG.md) - [Commits](paritytech/jsonrpsee@v0.20.0...v0.20.1) --- updated-dependencies: - dependency-name: jsonrpsee dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [clap](https://github.com/clap-rs/clap) from 4.4.2 to 4.4.3. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.4.2...v4.4.3) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

codegen/Cargo.toml

jsdw

I think we can remove the getrandom dep entirely now (see comment above) but otherwise looks great!

tadeohepperle added 8 commits August 25, 2023 14:01

minor api changes

8e1b637

parsing instead of format_ident!

dcc1f08

fix self issue

d11c76e

expose types on typegen

da83ec0

Merge branch 'master' into tadeo-hepperle-example-code-gen

0a91433

web wasm support via feature flag

6204c6d

Merge branch 'master' into tadeo-hepperle-example-code-gen

2fd6e5c

fmt and clippy

7dbae5d

tadeohepperle marked this pull request as ready for review September 12, 2023 07:45

tadeohepperle requested a review from a team as a code owner September 12, 2023 07:45

lexnv reviewed Sep 12, 2023

View reviewed changes

codegen/Cargo.toml Outdated Show resolved Hide resolved

tadeohepperle and others added 6 commits September 12, 2023 12:20

small adjustments

d196410

remove exposing of types() in type generator

5d9e817

adjust compile error

6281fd2

remove little any flag

3722035

Need access to the type registry from the typegen again

9f7a279

Merge branch 'master' into tadeo-hepperle-example-code-gen

7aa636a

jsdw reviewed Sep 15, 2023

View reviewed changes

codegen/src/api/mod.rs Outdated Show resolved Hide resolved

jsdw reviewed Sep 15, 2023

View reviewed changes

codegen/src/types/mod.rs Show resolved Hide resolved

jsdw reviewed Sep 15, 2023

View reviewed changes

codegen/src/api/storage.rs Outdated Show resolved Hide resolved

dependabot bot and others added 8 commits September 19, 2023 16:46

fix double quote import introduced by merge

d073f54

clippy

1cdf564

tadeohepperle requested a review from a team as a code owner September 19, 2023 14:48

Merge branch 'master' into tadeo-hepperle-example-code-gen

d16d5a7

niklasad1 reviewed Sep 19, 2023

View reviewed changes

codegen/Cargo.toml Outdated Show resolved Hide resolved

niklasad1 reviewed Sep 19, 2023

View reviewed changes

codegen/Cargo.toml Outdated Show resolved Hide resolved

tadeohepperle and others added 4 commits September 20, 2023 09:42

put ensure_unique_types on metadata, revert toml changes

8879c8f

fmt

05e1d09

solve frame_metadata import

47bed78

tidy fetch-metadata and non_exhaustive on errors

7f4fab9

jsdw approved these changes Sep 20, 2023

View reviewed changes

remove the getrandom thing

16ad86d

tadeohepperle force-pushed the tadeo-hepperle-example-code-gen branch from abee6e7 to 16ad86d Compare September 20, 2023 10:09

jsdw mentioned this pull request Sep 20, 2023

subxt-codegen: support web and fetch-metadata together? Tidy web. #1169

Closed

niklasad1 approved these changes Sep 20, 2023

View reviewed changes

fix toml autoformatting

1fbe008

tadeohepperle merged commit 12e3434 into master Sep 20, 2023

tadeohepperle deleted the tadeo-hepperle-example-code-gen branch September 20, 2023 11:16

jsdw mentioned this pull request Sep 27, 2023

Prep to release 0.32.0 #1178

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the codegen more accessible for running in WASM #1154

Make the codegen more accessible for running in WASM #1154

tadeohepperle commented Sep 8, 2023 •

edited

Loading

lexnv Sep 12, 2023

lexnv Sep 12, 2023

tadeohepperle Sep 12, 2023

niklasad1 Sep 20, 2023

jsdw left a comment

Make the codegen more accessible for running in WASM #1154

Make the codegen more accessible for running in WASM #1154

Conversation

tadeohepperle commented Sep 8, 2023 • edited Loading

lexnv Sep 12, 2023

Choose a reason for hiding this comment

lexnv Sep 12, 2023

Choose a reason for hiding this comment

tadeohepperle Sep 12, 2023

Choose a reason for hiding this comment

niklasad1 Sep 20, 2023

Choose a reason for hiding this comment

jsdw left a comment

Choose a reason for hiding this comment

tadeohepperle commented Sep 8, 2023 •

edited

Loading