git: Increase light client test timeout to 25 mins #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
approved these changes
Jul 13, 2023
|
We'll have to keep an eye on this and see if there is something we can do to speed it up or whatever; isn't it wayyy faster on macs for some reason that we don't really understand? |
|
Yep, indeed on Mac synching is way way faster. Might be interesting to see why/if compiling the wasm code represents the majority of that time (deduced from initial issue: smol-dot/smoldot#592 (comment)). It might be a case of not having enabled/supporting some hardware primitives for x86 (ie avx) that might be enabled on arm (ie neon); or something along those lines. |
tadeohepperle
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been filtered as flaky by our CI, increase the timeout to ensure the light client has proper time to sync with the chain and perform the tests.