This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Expose set_reserved_peers
#9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
added
A0-please_review
bkchr
approved these changes
Oct 7, 2021
tomaka
approved these changes
Oct 7, 2021
|
bot merge |
|
Merge aborted: Checks failed for d924036 |
|
bot merge |
|
Waiting for commit status. |
|
This bot really doesn't like me |
It's not you, it's a flaky test: https://gitlab.parity.io/parity/substrate/-/jobs/1163366 |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a safer API than add/remove as remove takes addresses although it only cares about
PeerIds which in the case of Polkadot resulted in a usage where we removed peers unintentionally: Because of the book keeping we did in Polkadot, which would calculate peers to be added/removed based on addresses.With
set_reserved_peersexposed, that book keeping can actually be removed from Polkadot all together - so can't become wrong 🙈 anymore.I also removed some seemingly redundant
clones.