Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

add note on --dev behavior #9953

Merged
6 commits merged into from
Oct 9, 2021
Merged

add note on --dev behavior #9953

6 commits merged into from
Oct 9, 2021

Conversation

nuke-web3
Copy link
Contributor

addresses #9938 (review)

@nuke-web3 nuke-web3 requested a review from apopiak October 6, 2021 23:38
@nuke-web3 nuke-web3 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 6, 2021
apopiak
apopiak approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ for adding the comment!
What do you think about this formulation?

@nuke-web3 @apopiak
Update client/cli/src/params/shared_params.rs
3ec6740 
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
@adoerr
Copy link
Contributor

adoerr commented Oct 9, 2021

bot merge

@ghost
Copy link

ghost commented Oct 9, 2021

Trying merge.

@ghost ghost merged commit 0e0cdd8 into master Oct 9, 2021
@ghost ghost deleted the NukeManDan-patch-2 branch October 9, 2021 06:16
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apopiak apopiak apopiak approved these changes

@gilescope gilescope gilescope approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@adoerr adoerr adoerr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nuke-web3 @adoerr @gilescope @shawntabrizi @apopiak