This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow Skipping Benchmark Errors #9699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B0-silent
emostov
reviewed
Sep 6, 2021
emostov
approved these changes
Sep 6, 2021
apopiak
approved these changes
Sep 6, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: "Required status check "continuous-integration/gitlab-check-polkadot-companion-build" is failing." |
|
failing CI is a flaky test |
|
bot force merge |
|
bot merge force |
|
Trying merge. |
|
Merge failed: "3 of 8 required status checks have not succeeded: 1 expected, 1 failing, and 1 pending." |
|
bot merge force |
|
Trying merge. |
|
Merge failed: "Required status check "continuous-integration/gitlab-check-polkadot-companion-build" is failing." |
|
bot merge |
|
Trying merge. |
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces yet another
BenchmarkErrortype which can allow the benchmarking pipeline to skip a benchmark when it returns an error, but continue the rest of the benchmarking pipeline. Not really great for pallet benchmarks, but can be helpful when skipping XCM features which are not enabled on the chain.