Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Clean up node-template #9667

Merged
2 commits merged into from
Sep 3, 2021
Merged

Clean up node-template #9667

2 commits merged into from
Sep 3, 2021

Conversation

cmichi
Copy link
Contributor

@cmichi cmichi commented Sep 1, 2021 •
edited
Loading

I recently used the node-template and those two things stood out to me:

@cmichi cmichi added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 1, 2021
gilescope
gilescope approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spots - LGTM.

@cmichi
Copy link
Contributor Author

cmichi commented Sep 3, 2021

bot merge

@ghost
Copy link

ghost commented Sep 3, 2021

Trying merge.

@ghost ghost merged commit c7a6264 into master Sep 3, 2021
@ghost ghost deleted the cmichi-clean-up-node-template branch September 3, 2021 01:32
@cmichi cmichi mentioned this pull request Sep 22, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gilescope gilescope gilescope approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmichi @gilescope @bkchr