Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update test-runner api #9302

Merged
merged 26 commits into from
Jul 12, 2021
Merged

Update test-runner api #9302

merged 26 commits into from
Jul 12, 2021

Conversation

seunlanlege
Copy link
Contributor

@seunlanlege seunlanlege commented Jul 7, 2021 •
edited
Loading

This refactors the test-runner api.

polkadot companion: paritytech/polkadot#2609

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jul 7, 2021
@seunlanlege seunlanlege changed the title Thank you for your Pull Request! Update test-runner api Jul 7, 2021
@seunlanlege seunlanlege added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 7, 2021
@seunlanlege seunlanlege mentioned this pull request Jul 8, 2021
Merged
@seunlanlege seunlanlege requested a review from ordian July 8, 2021 14:04
ordian
ordian reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with code, so would appreciate if someone else would take a look.

test-utils/test-runner/Cargo.toml Outdated Show resolved Hide resolved
test-utils/test-runner/src/utils.rs Outdated Show resolved Hide resolved
test-utils/test-runner/src/node.rs Outdated Show resolved Hide resolved
test-utils/test-runner/src/node.rs Outdated Show resolved Hide resolved
Seun Lanlege and others added 3 commits July 8, 2021 17:43
@seunlanlege
Copy link
Contributor Author

@ordian think this ok now?

@ordian
Copy link
Member

ordian commented Jul 9, 2021

@ordian think this ok now?

I'm not familiar with this code enough to be confident to give an approval, so would appreciate if someone else would do it.

@seunlanlege seunlanlege requested review from tomusdrw and cecton July 9, 2021 11:55
tomusdrw
tomusdrw approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the context is, but I'm assuming it's exposing the async/await functions instead of having a blocking API?

I also don't know exactly where/if this code is used, but the changes looks sane to me.

@seunlanlege
Copy link
Contributor Author

ui tests won't let me great :(

@seunlanlege seunlanlege merged commit 00de218 into master Jul 12, 2021
@seunlanlege seunlanlege deleted the test-runner-2 branch July 12, 2021 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

@ordian ordian ordian approved these changes

@bkchr bkchr Awaiting requested review from bkchr

@expenses expenses Awaiting requested review from expenses

@gnunicorn gnunicorn Awaiting requested review from gnunicorn

@cecton cecton Awaiting requested review from cecton

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seunlanlege @ordian @tomusdrw