This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
clean up staking docs, remove EraElectionStatus references #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
kianenigma
added
the
D2-notlive 💤
gui1117
approved these changes
Jul 6, 2021
In general, can we do this with all extrinsics? I think I remember Shawn mentioning these are deprecated with our current benchmarking stack |
Yeah once we have the storage info comments, all the other benchmarking comments could basically go away. However, it is still nice to keep information about the time complexity of a function, so when users modify code, they know what level of complexity they are working with, and dont change those assumptions. All functions should basically be linear. |
shawntabrizi
approved these changes
Jul 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported by an external user, don't recall their name but kudos to them for pointing out.
I also got rid of some of the superfluous weight comments. With #9090 we can remove almost all of them, actually.