Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

change reference module to pallet #9281

Merged
2 commits merged into from
Jul 6, 2021
Merged

change reference module to pallet #9281

2 commits merged into from
Jul 6, 2021

Conversation

ashWhiteHat
Copy link
Contributor

I changed the rust docs reference according to the latest update.
Please confirm.
Thank you.

@kianenigma
Copy link
Contributor

@TriplEight aren't these README files autogenerated based on code docs? in that case the code should be changed, not the readme.

kianenigma
kianenigma suggested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change the code doc, not the .md file.

@gui1117
Copy link
Contributor

gui1117 commented Jul 6, 2021

I believe the inner doc in the rust file are already fixed and so the readme should be fixed when publishing next version, but if not then yes they should be.

@gui1117 gui1117 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 6, 2021
@kianenigma
Copy link
Contributor

Hmm this one is not, the rest are fine. 🤷
https://github.com/paritytech/substrate/blob/master/frame/assets/src/lib.rs#L115

@gui1117
Copy link
Contributor

gui1117 commented Jul 6, 2021

bot merge

@ghost
Copy link

ghost commented Jul 6, 2021

Waiting for commit status.

@ghost ghost merged commit bf43f74 into paritytech:master Jul 6, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@kianenigma kianenigma kianenigma approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashWhiteHat @kianenigma @gui1117 @shawntabrizi