Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Removed score and compute from set_emergency_election_result #9271

Merged

Conversation

leonardocustodio
Copy link
Contributor

This PR fixes the issue on #9204

As @kianenigma said the score and compute parameters are byes of the transaction.
So as suggested I altered the function to only receive the supports, hardcoded the score and made a new Emergency compute variant.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jul 5, 2021

User @leonardocustodio, please sign the CLA here.

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkchr bkchr requested a review from coriolinus July 5, 2021 18:38
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 6, 2021
@bkchr bkchr merged commit c95f862 into paritytech:master Jul 6, 2021
@leonardocustodio leonardocustodio deleted the issue-9204-emergency-election-result branch December 18, 2021 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants