This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update pallet macro migrations. #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B0-silent
shawntabrizi
approved these changes
May 9, 2021
|
I dont think All dispatchables are basically pub through the |
bkchr
suggested changes
May 10, 2021
bkchr
approved these changes
May 10, 2021
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* Update pallet macro migrations. * Revert dispatchable call visibility changes. * fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8762 (comment)
Updated some of the merged pallet macro migrations:
DispatchResultWithPostInfowithDispatchResult.After second check I noticed the visibility of several dispatchable calls was made topubin pallet macro migration, but it should bepub(crate).