Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate pallet-offences to pallet attribute macro #8763

Merged
7 commits merged into from
May 12, 2021

Conversation

stanly-johnson
Copy link
Contributor

Part of #7882.

Converts the Offences pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented May 8, 2021

User @stanly-johnson, please sign the CLA here.

@shawntabrizi
Copy link
Member

some other spots where tabs needed too

@shawntabrizi
Copy link
Member

Also compile locally to check for unused imports like this:

error: unused import: `StorageMap`
  --> frame/offences/src/mock.rs:34:19
   |
34 |     parameter_types, StorageMap, StorageDoubleMap,
   |                      ^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
error: unused import: `StorageDoubleMap`
  --> frame/offences/src/mock.rs:34:31
   |
34 |     parameter_types, StorageMap, StorageDoubleMap,

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels May 9, 2021
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

frame/offences/src/lib.rs Outdated Show resolved Hide resolved
frame/offences/src/lib.rs Show resolved Hide resolved
frame/offences/src/lib.rs Outdated Show resolved Hide resolved
@gui1117 gui1117 added A0-please_review Pull request needs code review. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed B0-silent Changes should not be mentioned in any release notes labels May 12, 2021
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented May 12, 2021

Waiting for commit status.

@ghost ghost merged commit af14d49 into paritytech:master May 12, 2021
@viniul viniul added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels May 28, 2021
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
* update to pallet macro

* fixes

* fix tests

* remove unwanted generic

* fix conflict

* Fix storage and tabs

Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants